Repository navigation
[CP Staging] Revert optimistic scan-failed expense move on pay - #98914
Conversation
Reverts PR 97084 to clear deploy blocker 98821. Co-authored-by: Claude <claude@anthropic.com>
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
Revert optimistic scan-failed expense move on pay (cherry picked from commit d35e85c) (cherry-picked to staging by Beamanator)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.55-4 🚀
|
|
🔁 Filed a Staging retest request for deploy blockers #98821 after this PR was cherry-picked to staging. |
|
🤖 No help site changes required — no draft PR created. This PR reverts PR #97084, restoring the behavior production already runs. The diff is limited to internal client-side logic and its tests:
The change concerns how a scan-failed expense is handled on Pay (optimistic report creation vs. leaving the expense in place until the backend moves it on reconnect). This is implementation behavior that is invisible to end users and is not documented anywhere in Since the revert introduces no new or changed public behavior, the help site remains accurate as-is. @deetergp, no help site PR was needed here, so there's nothing to review — flagging for your awareness. If you believe a docs update is warranted, let me know what behavior should be documented and I'll draft one. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.55-4 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.56-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Reverts PR 97084, which caused the deploy blocker.
PR 97084 optimistically creates a client-side report for a scan-failed expense on Pay. The backend then creates its own report with a different ID, so the optimistic report is deleted in
successDataon reconnect. A user who is viewing that optimistic report lands on the "Hmm... it's not here" page.This revert restores the behaviour that production runs today. The scan-failed expense stays in the report until reconnect, and the backend moves it.
Note on the revert:
src/libs/TransactionUtils/index.tsneeded a manual conflict resolution. Commit05eb2df("Revert #96772") removedisFailedScanAmountPlaceholderafter PR 97084 merged, so the pre-97084 export of that symbol must not come back. The resolution keeps neither side of the conflict. The other five files are byte-identical to their pre-97084 state.This revert reopens issue 96257, which is Weekly priority.
Fixed Issues
$ #98821
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari